Comments on: PHP Parsing and a new album http://mpbedard.blogs.plymouth.edu/2008/10/14/php-parsing-and-a-new-album/ The life and times of the Mac Jedi. Tue, 06 Jan 2009 04:18:19 -0500 http://wordpress.org/?v=2.8.6 hourly 1 By: Zach http://mpbedard.blogs.plymouth.edu/2008/10/14/php-parsing-and-a-new-album/comment-page-1/#comment-373 Zach Sun, 19 Oct 2008 01:33:28 +0000 http://mpbedard.blogs.plymouth.edu/?p=20#comment-373 In the log parsing, you could have saved one whole loop by doing lines 16-19 in the same loop as the preg_match_all(). Also, the preg_match_all could have been accomplished more efficiently with preg_match() *or* you could have done one preg_match_all() without the initial loop and moved straight into line 15s loop as is. Minor stuff, but a slightly cleaner approach. Otherwise, huge props for attempting the regexp. In the image gallery code, you could have simplified a bit by leveraging the modulus operator as opposed to multiple loops. Again, just a tip on cleanliness. Good forward thinking with the nicely standardized naming convention for the images. Any thoughts on how you might handle this if they weren't so neatly structured? In the log parsing, you could have saved one whole loop by doing lines 16-19 in the same loop as the preg_match_all(). Also, the preg_match_all could have been accomplished more efficiently with preg_match() *or* you could have done one preg_match_all() without the initial loop and moved straight into line 15s loop as is. Minor stuff, but a slightly cleaner approach. Otherwise, huge props for attempting the regexp.

In the image gallery code, you could have simplified a bit by leveraging the modulus operator as opposed to multiple loops. Again, just a tip on cleanliness.

Good forward thinking with the nicely standardized naming convention for the images. Any thoughts on how you might handle this if they weren’t so neatly structured?

]]>